Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures with gcc -O2 #448

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Fix test failures with gcc -O2 #448

merged 4 commits into from
Jun 28, 2024

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Jun 27, 2024

Fixes #440

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.25%. Comparing base (e837309) to head (8c273eb).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
src/c4/yml/parse.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   97.24%   97.25%           
=======================================
  Files          33       33           
  Lines       11259    11273   +14     
=======================================
+ Hits        10949    10963   +14     
  Misses        310      310           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biojppm biojppm force-pushed the fix/440 branch 3 times, most recently from 8a6ad6d to 2282cde Compare June 28, 2024 18:53
@biojppm biojppm changed the title Fix/440 Fix test failures with gcc -O2 Jun 28, 2024
@biojppm
Copy link
Owner Author

biojppm commented Jun 28, 2024

For some reason the CI checks are not triggering. Running the gcc workflow manually confirms that the repro is working: see https://github.com/biojppm/rapidyaml/actions/runs/9717240536/job/26822517972 .

@biojppm
Copy link
Owner Author

biojppm commented Jun 28, 2024

This workflow shows the fix is working: https://github.com/biojppm/rapidyaml/actions/runs/9717245009/job/26822534347

@biojppm
Copy link
Owner Author

biojppm commented Jun 28, 2024

The failures are unrelated with this changeset, and will be dealt with separately. Merging now.

@biojppm biojppm merged commit 619ad08 into master Jun 28, 2024
234 of 239 checks passed
@biojppm biojppm deleted the fix/440 branch June 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some test failures in 0.7.0 when compiled gcc -O2
1 participant